[libc++] Remove some of the uses of aligned_storage inside the library #161635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
philnik777
force-pushed
the
remove_aligned_storage
branch
from
ff4ed62 to
6dae88f
Compare
ldionne
reviewed
Oct 8, 2025
| _LIBCPP_SUPPRESS_DEPRECATED_PUSH | ||
| using _Buffer _LIBCPP_NODEBUG = aligned_storage_t<3 * sizeof(void*), alignof(void*)>; | ||
| _LIBCPP_SUPPRESS_DEPRECATED_POP | ||
| inline constexpr size_t __small_buffer_size = 3 * sizeof(void*); |
There was a problem hiding this comment.
I found the previous code easier to read since we did sizeof(_Buffer) and alignof(_Buffer) below. What would you think of using _Buffer = alignas(alignment) char [size] instead?
There was a problem hiding this comment.
You can't put alignas on an alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aligned_storagehas been deprecated and will most likely be removed in a future version of C++. This patch removes some of its uses to avoid having to work around its removal in the future.